refactor: Combine promo list and create endpoints, update tests#35
Merged
RandomProgramm3r merged 2 commits intomainfrom Apr 29, 2025
Merged
refactor: Combine promo list and create endpoints, update tests#35RandomProgramm3r merged 2 commits intomainfrom
RandomProgramm3r merged 2 commits intomainfrom
Conversation
Replaced separate views for listing and creating company promos with a single CompanyPromoListCreateView based on ListCreateAPIView. This simplifies the API by handling GET and POST requests for promos at a single URL endpoint (`api/business/promo`). - Uses get_serializer_class for appropriate request methods. - Moved query param validation into the list method. - Updated urls.py to point to the new combined view. - Remove redundant imports in serializers.
Updated the test setup to reflect the merged promo endpoints. Replaced `cls.promo_create_url` and `cls.promo_list_url` with a single `cls.promo_list_create_url` using the reversed URL name 'api-business:promo-list-create'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced separate views for listing and creating company promos
with a single CompanyPromoListCreateView based on ListCreateAPIView.
This simplifies the API by handling GET and POST requests for promos
at a single URL endpoint (
api/business/promo).